Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug in host network info collector #2821

Merged

Conversation

eparla774
Copy link
Contributor

Fixed bug in host network info collector (Issue #2779)

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works. (New tests not needed)

If API endpoints of add-on configuration are added/changed:

Fixed bug in host network info collector (Issue home-assistant#2779)
@homeassistant
Copy link

Hi @eparla774,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

if not inet.settings.wireless_security:
psk = None
else:
psk = inet.settings.wireless_security.psk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this into structure above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this into structure above
Added

@pvizeli pvizeli added the bugfix A bug fix label Apr 26, 2021
@pvizeli pvizeli merged commit 9e67df2 into home-assistant:main Apr 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in host network info collector
3 participants