Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fixtures #2946

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Rename fixtures #2946

merged 2 commits into from
Jun 10, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jun 9, 2021

Proposed change

Renames fixtures containing * to make clone (and other git operations) possible on Windows
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@ludeeus ludeeus added the refactor A code change that neither fixes a bug nor adds a feature label Jun 9, 2021
@pvizeli
Copy link
Member

pvizeli commented Jun 10, 2021

does it work with tilde? I used the star because it can never conflict with a possible dbus name

@ludeeus
Copy link
Member Author

ludeeus commented Jun 10, 2021

Looks like that should work as well

@pvizeli pvizeli merged commit b70ed9a into main Jun 10, 2021
@pvizeli pvizeli deleted the rename-fixtures branch June 10, 2021 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludeeus @pvizeli @homeassistant