Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new format for logging exceptions - docker/network.py #3220

Merged
merged 2 commits into from Oct 18, 2021
Merged

Use new format for logging exceptions - docker/network.py #3220

merged 2 commits into from Oct 18, 2021

Conversation

vighnesh-kadam
Copy link
Contributor

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

ludeeus
ludeeus requested changes Oct 11, 2021
View reviewed changes
supervisor/docker/network.py Outdated Show resolved Hide resolved
@ludeeus ludeeus added Hacktoberfest refactor A code change that neither fixes a bug nor adds a feature labels Oct 11, 2021
ludeeus
ludeeus approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@ludeeus ludeeus merged commit a90f70e into home-assistant:main Oct 18, 2021
@vighnesh-kadam vighnesh-kadam deleted the docks branch October 18, 2021 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ludeeus ludeeus ludeeus approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vighnesh-kadam @ludeeus @homeassistant