Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unsupported reason container to software #3240

Merged
merged 4 commits into from Oct 19, 2021
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Oct 18, 2021

Proposed change

  • Rename the unsupported reason "container" to "software" to be more in line with the ADR.
    • The evaluation file and therefore also the slug has been kept as container since this only cheks containers
  • Uses the meta config of the container to get the image name (same as the DockerInterface class uses) to fix the issue on dev now where the supervisor image trigger unsupported status.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@ludeeus ludeeus added the refactor A code change that neither fixes a bug nor adds a feature label Oct 18, 2021
@pvizeli pvizeli merged commit ef5b6a5 into main Oct 19, 2021
@pvizeli pvizeli deleted the sotware-eveluation branch October 19, 2021 09:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants