Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct import from docker modules to get better typing #3266

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Oct 26, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@ludeeus ludeeus added refactor A code change that neither fixes a bug nor adds a feature and removed cla-signed labels Oct 26, 2021
@pvizeli pvizeli added refactor A code change that neither fixes a bug nor adds a feature and removed refactor A code change that neither fixes a bug nor adds a feature labels Oct 26, 2021
@pvizeli pvizeli merged commit 828cf77 into main Oct 26, 2021
@pvizeli pvizeli deleted the docker-typing branch October 26, 2021 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants