backups: Add support for creating fully uncompressed backups #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
uncompressed-backups
branch
2 times, most recently
from
38e893e
to
879f01a
Compare
|
Need update the CLI + Our API documentation |
3v1n0
force-pushed
the
uncompressed-backups
branch
from
879f01a
to
006883a
Compare
3v1n0
added a commit
to 3v1n0/ha-cli
that referenced
this pull request
Jan 19, 2022
Backups can be optionally uncompressed so provide command line flags to request that. Related to: home-assistant/supervisor#3378
3v1n0
added a commit
to 3v1n0/developers.home-assistant
that referenced
this pull request
Jan 19, 2022
5 tasks
@pvizeli Took a bit, but added the CLI and API docs updates |
|
CI still not pass |
pvizeli
reviewed
Jan 24, 2022
3v1n0
force-pushed
the
uncompressed-backups
branch
from
006883a
to
5bd5de0
Compare
Hassio supervisor saves backups in tar files that contains compressed tar archives, this is convenient when such backups are kept in the same environment or need to be transferred remotely, but it's not convenient when they will be processed using other backup tools such as borg or restic that can handle compression, encryption and data deduplication themselves. In fact deduplication won't actually work at all with hassio compressed backups as there's no way to find common streams for such tools (unless we make them to export the archives during importing as borg's import-tar can do), but this would lead to archives that are not easily recoverable by the supervisor. So, make possible to pass a "compressed" boolean parameter when creating backups that will just archive all the data uncompressed. It will be then up to other tools to manage the archives compression.
pvizeli
approved these changes
Feb 3, 2022
pvizeli
pushed a commit
to home-assistant/developers.home-assistant
that referenced
this pull request
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Hassio supervisor saves backups in tar files that contains compressed
tar archives, this is convenient when such backups are kept in the same
environment or need to be transferred remotely, but it's not convenient
when they will be processed using other backup tools such as borg or
restic that can handle compression, encryption and data deduplication
themselves.
In fact deduplication won't actually work at all with hassio compressed
backups as there's no way to find common streams for such tools (unless
we make them to export the archives during importing as borg's
import-tar can do), but this would lead to archives that are not easily
recoverable by the supervisor.
So, make possible to pass a "compressed" boolean parameter when creating
backups that will just archive all the data uncompressed.
It will be then up to other tools to manage the archives compression.
Type of change
Additional information
Checklist
black --fast supervisor tests)If API endpoints of add-on configuration are added/changed: