Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESPHome default repo for new installations #3430

Merged
merged 2 commits into from
Feb 8, 2022
Merged

ESPHome default repo for new installations #3430

merged 2 commits into from
Feb 8, 2022

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 3, 2022

Proposed change

Add ESPHome to the default repositories

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added the new-feature A new feature label Feb 3, 2022
ludeeus
ludeeus reviewed Feb 3, 2022
View reviewed changes
supervisor/validate.py Outdated Show resolved Hide resolved
@ludeeus ludeeus changed the title ESPHome default repo ESPHome default repo for new installations Feb 3, 2022
jesserockz
jesserockz reviewed Feb 8, 2022
View reviewed changes
supervisor/validate.py Outdated Show resolved Hide resolved
@ludeeus ludeeus mentioned this pull request Feb 8, 2022
Merged
@ludeeus @jesserockz
Update supervisor/validate.py
ea47997 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@balloob balloob merged commit 787695a into main Feb 8, 2022
@balloob balloob deleted the esphome branch February 8, 2022 22:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz left review comments

@ludeeus ludeeus ludeeus approved these changes

@frenck frenck frenck approved these changes

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed new-feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pvizeli @frenck @balloob @jesserockz @ludeeus @homeassistant