Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Backup format for core #3451

Merged
merged 23 commits into from
Feb 23, 2022
Merged

New Backup format for core #3451

merged 23 commits into from
Feb 23, 2022

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 16, 2022

Proposed change

  • Handle core/homeassistant like an add-on with on full feature folder and settings.
  • Simplify the code
  • Offload our SecureTar into own Module
  • Add version handling to handling different backup format in future

It's not a real breaking change but we handle the homeassistant core folder now out of the folder list (but we support still the old format) - You can now not restore the core config without core itself which will also represent the core today and his internal database. People should also stop to use core folder for own configs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added the refactor A code change that neither fixes a bug nor adds a feature label Feb 17, 2022
@pvizeli pvizeli added breaking-change and removed refactor A code change that neither fixes a bug nor adds a feature labels Feb 17, 2022
@pvizeli pvizeli marked this pull request as ready for review February 21, 2022 13:21
supervisor/backups/backup.py Show resolved Hide resolved
supervisor/homeassistant/module.py Show resolved Hide resolved
supervisor/backups/backup.py Outdated Show resolved Hide resolved
supervisor/backups/manager.py Outdated Show resolved Hide resolved
@pvizeli pvizeli requested a review from ludeeus February 23, 2022 14:09
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

supervisor/exceptions.py Outdated Show resolved Hide resolved
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
@ludeeus
Copy link
Member

ludeeus commented Feb 23, 2022

Regarding "You can now not restore the core config without core itself which will also represent the core today and his internal database. People should also stop to use core folder for own configs"

Should the frontend, CLI and core service calls be updated to make sure to include homeassistant: True if the core config dir is present in the backup?

@pvizeli
Copy link
Member Author

pvizeli commented Feb 23, 2022

It's backward compatible. The breaking change is more logical. But I will look into CLI to add an option for it, if that is not exists today

@pvizeli pvizeli merged commit 9104b28 into main Feb 23, 2022
@pvizeli pvizeli deleted the new-backup-format branch February 23, 2022 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants