Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CAS configs to image #3462

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Add CAS configs to image #3462

merged 1 commit into from
Feb 23, 2022

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 23, 2022

Proposed change

Merged after: https://github.com/home-assistant/version/pull/207/files

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01
Copy link
Contributor

I see, that's this file: https://github.com/codenotary/cas/blob/master/docs/user-guide/configuration.md . That doc is also a bit confusing since it says on linux it makes the file in /tmp but in the help for the command it says it makes it in the home directory. Based on the error we're getting from apparmor it appears the latter is true.

I guess normally it just makes it temporarily and then I assume cleans it up after? Explains why we didn't notice it before.

@mdegat01 mdegat01 merged commit 36f4e49 into main Feb 23, 2022
@mdegat01 mdegat01 deleted the add-cas-config branch February 23, 2022 22:31
@pvizeli
Copy link
Member Author

pvizeli commented Feb 24, 2022

it drops in with my 1.0.2 update before. You worked with 1.0.1

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants