Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsupported message if no systemd-resolved #3487

Merged
merged 2 commits into from Mar 7, 2022
Merged

Add unsupported message if no systemd-resolved #3487

merged 2 commits into from Mar 7, 2022

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Mar 5, 2022 •
edited

Proposed change

Mark system as unsupported if systemd-resolved is not available on host because DNS will not work properly without it after latest changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added enhancement missing-documentation Added to pull requests that needs a docs, but none is linked labels Mar 5, 2022
@mdegat01 mdegat01 requested a review from pvizeli March 5, 2022 18:59
@mdegat01 mdegat01 mentioned this pull request Mar 6, 2022
Merged
8 tasks
@mdegat01 mdegat01 removed the missing-documentation Added to pull requests that needs a docs, but none is linked label Mar 6, 2022
pvizeli
pvizeli approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should followup make sure that at least mdsn is enabled as check and enable it as fixup

@pvizeli pvizeli added new-feature A new feature and removed enhancement labels Mar 7, 2022
@pvizeli pvizeli merged commit dd3a4a1 into main Mar 7, 2022
@pvizeli pvizeli deleted the systemd-resolver-required branch March 7, 2022 09:38
@ludeeus ludeeus mentioned this pull request Mar 7, 2022
Merged
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed new-feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdegat01 @pvizeli @homeassistant