-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MDNS and LLMNR status to API #3545
Conversation
@pvizeli I should note that when going through this I realized something. I cannot add Which means it is possible for this to return If so I'll do the second part in a separate PR though since I'd have to explore org.freedesktop.resolve1.Link and see how the info in NetworkManager matches up (since org.freedesktop.resolve1 just has a |
While it is nice, I think I'd rather prefer to have it not at all then it to be "unreliable". IMHO, it should reflect the current active network profiles setting and be in the dns options. Exposing the global setting in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with that and looking how it goes
Remember to create a dev documentation PR when the API changes 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Proposed change
Add MDNS and LLMNR status to
/dns/info
. Returns true if MDNS and LLMNR are enabled in systemd-resolved, returns false if they are disabled or systemd-resolved is unreachable (as then the DNS plugin will not be able to resolve these names).Also added
llmnr_hostname
to/host/info
. Usually this will be identical tohostname
. But it is possible for it to be different if there was a conflict on the network (like say if there was another machine already namedhomeassistant
). Figured it might help someone debug a tricky situation.Lastly added
resolved
to host features in/host/info
. I missed this when I added resolved, I feel like it should be there.Type of change
Additional information
Checklist
black --fast supervisor tests
)If API endpoints of add-on configuration are added/changed: