Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch names can contain periods #3721

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Branch names can contain periods #3721

merged 1 commit into from
Jul 7, 2022

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Jul 7, 2022

Proposed change

Screen Shot 2022-07-07 at 11 54 49 AM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Jul 7, 2022
@mdegat01 mdegat01 requested a review from pvizeli July 7, 2022 15:55
@pvizeli pvizeli merged commit 8b7aa76 into main Jul 7, 2022
@pvizeli pvizeli deleted the branches-periods branch July 7, 2022 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
bugfix A bug fix cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdegat01 @pvizeli @homeassistant