Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max line size for ingress addons #3747

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Jul 19, 2022

Proposed change

Some ingress addons require very long URLs. Since all access to ingress addons goes through supervisor's API they are subject to whatever we set as for max_line_size and max_field_size in aiohttp. This can create issues like #3737 . Increasing it should support more addons.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Jul 19, 2022
@mdegat01 mdegat01 requested a review from pvizeli July 19, 2022 19:32
@pvizeli
Copy link
Member

pvizeli commented Jul 25, 2022

This need to be added also to the core ingress handler @mdegat01

@pvizeli pvizeli merged commit 13db0e5 into main Jul 25, 2022
@pvizeli pvizeli deleted the increase-max-line-size branch July 25, 2022 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow-up: Query URL max length of 8190 bytes is critical in ingress/add-on use
3 participants