Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert Home Assistant configuration to /config" #4702

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 13, 2023

Reverts #4697

As discussed, reverting this change.

Reasoning:

  • /config will always point to the active config in the matching container. The Home Assistant container will have its config in /config, all plugins have their config in /config and add-ons will now have their config in /config too.
  • /homeassistant is where other containers can access the Home Assistant configuration (if needed, but in general, their should not need it).

The above will add consistency to the developer experience (as part of the original intention was for this specific case).

For user-facing add-ons (like ssh, samba, vscode, file editor, e.d.), they will be adopted that they map config to /homeassistant, so that the change is transparent/non-breaking from the user experience.

Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Granted, it makes things consistent technically... But I think this adds more confusion than necessary (as stated in #4697).

But if this is preferred way to go, I am ok with it!

@frenck frenck merged commit bef0f02 into main Nov 13, 2023
21 of 22 checks passed
@frenck frenck deleted the revert-4697-revert-config-naming-to-avoid-confusion branch November 13, 2023 19:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants