Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon devs can block auto update for breaking versions #4832

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Jan 23, 2024

Proposed change

Provide addon developers with a way to list breaking versions of their addons. This way we can block auto-updates which would cross one of these breaking versions and prevent bad situations like what happened recently with Nginx Proxy Manager.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added new-feature A new feature missing-documentation Added to pull requests that needs a docs, but none is linked labels Jan 23, 2024
@mdegat01 mdegat01 removed the missing-documentation Added to pull requests that needs a docs, but none is linked label Jan 23, 2024
@pvizeli pvizeli merged commit ddadbec into main Jan 26, 2024
25 of 26 checks passed
@pvizeli pvizeli deleted the breaking-versions-addons branch January 26, 2024 07:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants