Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset failed API call counter on successful API call #4862

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

agners
Copy link
Member

@agners agners commented Jan 31, 2024

Proposed change

Make sure to reset the failed API call counter after a successful API call. While at it also update the log messages a bit to make it clearer what the problem is exactly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@agners agners added the bugfix A bug fix label Jan 31, 2024
@agners agners changed the title Reset failed API calls on success Reset failed API calls counter on success Jan 31, 2024
@agners agners changed the title Reset failed API calls counter on success Reset failed API call counter on success Jan 31, 2024
@agners agners changed the title Reset failed API call counter on success Reset failed API call counter on successful API call Jan 31, 2024
@agners agners force-pushed the reset-api-attempts-on-success branch from d2f5718 to 2e795c9 Compare January 31, 2024 13:52
Make sure to reset the failed API call counter after a successful
API call. While at it also update the log messages a bit to make it
clearer what the problem is exactly.
@agners agners requested a review from mdegat01 January 31, 2024 15:47
@agners agners marked this pull request as ready for review January 31, 2024 15:47
@agners agners force-pushed the reset-api-attempts-on-success branch from 2e795c9 to dc6aa93 Compare January 31, 2024 16:13
@mdegat01 mdegat01 merged commit 1908940 into main Jan 31, 2024
22 of 23 checks passed
@mdegat01 mdegat01 deleted the reset-api-attempts-on-success branch January 31, 2024 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants