Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark issues in FixupBase abstract #5033

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

agners
Copy link
Member

@agners agners commented Apr 22, 2024

Proposed change

Since #5024 all fixups have an associated issue. Generally, it is generally better to have an issue for every fixup so that things can be mapped to repairs in Core easily. Let's mark the issues property as abstract to indicate subclasses are required to implement it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Since #5024 all fixups have an associated issue. Generally, it is
generally better to have an issue for every fixup so that things
can be mapped to repairs in Core easily. Let's mark the issues property
as abstract to indicate subclasses are required to implement it.
@agners agners added the refactor A code change that neither fixes a bug nor adds a feature label Apr 22, 2024
@mdegat01 mdegat01 merged commit 221292a into main Apr 29, 2024
20 checks passed
@mdegat01 mdegat01 deleted the make-issues-property-abstract branch April 29, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants