Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip udisks listener on failure to connect #5049

Merged
merged 1 commit into from
May 1, 2024
Merged

Skip udisks listener on failure to connect #5049

merged 1 commit into from
May 1, 2024

Conversation

mdegat01
Copy link
Contributor

Proposed change

If we fail to connect to UDisks at load, don't try to set up the signal listeners.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Apr 30, 2024
@mdegat01 mdegat01 requested a review from agners April 30, 2024 20:05
@agners
Copy link
Member

agners commented May 1, 2024

It seems that this also happened on HAOS 12.2 on a Raspberry Pi 4:
https://community.home-assistant.io/t/after-latest-update-of-supervisor-2024-4-4-getting-unhealthy-system

At this point it is unclear why this happens as UDisks2 really should be running on this system.

@agners agners merged commit 1ac506b into main May 1, 2024
20 checks passed
@agners agners deleted the fix-udisks-none-error branch May 1, 2024 08:50
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agners agners agners approved these changes

Assignees
No one assigned
Labels
bugfix A bug fix cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdegat01 @agners