Skip to content

Commit

Permalink
Reopening #51 - this commit illustrates the problem (and breaks the b…
Browse files Browse the repository at this point in the history
…uild).
  • Loading branch information
climategadgets committed May 18, 2021
1 parent 4a3a94e commit a61f6d2
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private void testSync(String marker, Class<? extends AbstractDamperController> c
Damper damperWestBathroom = new SwitchDamper("damper_westbathroom", switchWestBathroom, 0.8, 1.0, 10);

Damper damperWest = new SwitchDamper("damper_west", switchWestDamper, 0.8, 1.0, 10);
Damper damperWestBoosterFan = new SwitchDamper("damper_westboosterfan", switchWestBoosterFan, 0.8, 1.0, 10, true);
Damper damperWestBoosterFan = new SwitchDamper("damper_westboosterfan", switchWestBoosterFan, 0.8, 0.0, 10, true);

Set<Damper> west = new LinkedHashSet<>();

Expand Down Expand Up @@ -185,7 +185,7 @@ private void testSync(String marker, Class<? extends AbstractDamperController> c
assertEquals(WRONG_STATE, true, switchKitchen.getState());
assertEquals(WRONG_STATE, true, switchWestBathroom.getState());
assertEquals(WRONG_STATE, true, switchWestDamper.getState());
assertEquals(WRONG_STATE, false, switchWestBoosterFan.getState());
assertEquals(WRONG_STATE, true, switchWestBoosterFan.getState());

// The above stateChanged() also changed the state of the Unit to "running",
// next stateChanged() will be handled differently
Expand Down Expand Up @@ -234,7 +234,7 @@ private void testSync(String marker, Class<? extends AbstractDamperController> c
assertEquals(WRONG_STATE, true, switchKitchen.getState());
assertEquals(WRONG_STATE, true, switchWestBathroom.getState());
assertEquals(WRONG_STATE, true, switchWestDamper.getState());
assertEquals(WRONG_STATE, false, switchWestBoosterFan.getState());
assertEquals(WRONG_STATE, true, switchWestBoosterFan.getState());

logger.info("Damper map: {}", Arrays.asList(dc.getDamperMap()));

Expand Down

0 comments on commit a61f6d2

Please sign in to comment.