Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle: check actual bottle block contents when --keep-old #10190

Merged
merged 2 commits into from Jan 1, 2021

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Dec 31, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR restores some of the brew bottle --merge --write --keep-old logic that was removed in #10102

Instead of checking for default spec values, we can check which methods were being called in the old bottle block

Supersedes #10135

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-01 at 17:58:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 31, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 1, 2021
@SeekingMeaning
Copy link
Contributor Author

Merging now so @iMichka can continue work on the new cellar syntax—I can open a follow-up PR if any changes are requested after merge

@SeekingMeaning SeekingMeaning merged commit e5eb6a2 into Homebrew:master Jan 1, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants