bottle: check actual bottle block contents when --keep-old#10190
Merged
SeekingMeaning merged 2 commits intoHomebrew:masterfrom Jan 1, 2021
Merged
bottle: check actual bottle block contents when --keep-old#10190SeekingMeaning merged 2 commits intoHomebrew:masterfrom
--keep-old#10190SeekingMeaning merged 2 commits intoHomebrew:masterfrom
Conversation
Contributor
|
Review period will end on 2021-01-01 at 17:58:13 UTC. |
bde4934 to
4cbd4f2
Compare
iMichka
approved these changes
Jan 1, 2021
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Jan 1, 2021
Contributor
Author
|
Merging now so @iMichka can continue work on the new cellar syntax—I can open a follow-up PR if any changes are requested after merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?This PR restores some of the
brew bottle --merge --write --keep-oldlogic that was removed in #10102Instead of checking for default spec values, we can check which methods were being called in the old
bottleblockSupersedes #10135