Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions/zsh: add-cask-option #10226

Merged

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Jan 5, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

add cask options to commands( reinstall and upgrade ) in zsh/completions.

@hyuraku hyuraku force-pushed the completions/zsh_add-cask-option branch from f6fcac0 to cb592ae Compare January 6, 2021 00:28
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @hyuraku but I'd like to pause any more completions changes until #10229 is merged.

@hyuraku
Copy link
Contributor Author

hyuraku commented Jan 6, 2021

I'd like to pause any more completions changes until #10229 is merged.

Sure.

@hyuraku
Copy link
Contributor Author

hyuraku commented Jan 20, 2021

@MikeMcQuaid

but I'd like to pause any more completions changes until #10229 is merged.

#10229 was merged, how about?

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid

but I'd like to pause any more completions changes until #10229 is merged.

#10229 was merged, how about?

Thanks @hyuraku! I'm interested in what @Rylan12 thinks here (as this may well be either autogenerated soon or cause him merge conflicts).

@hyuraku
Copy link
Contributor Author

hyuraku commented Jan 20, 2021

Thanks @hyuraku! I'm interested in what @Rylan12 thinks here

I understood that is my plan is to work on those next (probably zsh before fish). from #10229. I wait till merging it.

@Rylan12
Copy link
Member

Rylan12 commented Jan 20, 2021

I think it's okay to merge to temporarily fix completions, but this change will be overridden soon once these are generated. Don't worry about merge conflicts here: I'm not far enough along for them to be a big deal at the moment (especially because resolving them will simply be "use my changes instead").

I up to you two I guess. Probably not needed as these will be automatic soon, but doesn't hurt to temporarily have in case there's a new brew release before I get those completions working.

Does that give you enough to go on or do you want me to make the decision?

@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku!

@hyuraku hyuraku force-pushed the completions/zsh_add-cask-option branch from cb592ae to 7e2db0c Compare January 21, 2021 10:02
@MikeMcQuaid MikeMcQuaid merged commit 91759ac into Homebrew:master Jan 21, 2021
@hyuraku hyuraku deleted the completions/zsh_add-cask-option branch January 21, 2021 12:11
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 21, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants