New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completions/zsh: add-cask-option #10226
completions/zsh: add-cask-option #10226
Conversation
f6fcac0
to
cb592ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. |
I think it's okay to merge to temporarily fix completions, but this change will be overridden soon once these are generated. Don't worry about merge conflicts here: I'm not far enough along for them to be a big deal at the moment (especially because resolving them will simply be "use my changes instead"). I up to you two I guess. Probably not needed as these will be automatic soon, but doesn't hurt to temporarily have in case there's a new brew release before I get those completions working. Does that give you enough to go on or do you want me to make the decision? |
Thanks again @hyuraku! |
cb592ae
to
7e2db0c
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?add cask options to commands( reinstall and upgrade ) in zsh/completions.