completions/zsh: add-cask-option#10226
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jan 21, 2021
Merged
Conversation
f6fcac0 to
cb592ae
Compare
MikeMcQuaid
requested changes
Jan 6, 2021
Contributor
Author
Sure. |
Contributor
Author
Member
|
I think it's okay to merge to temporarily fix completions, but this change will be overridden soon once these are generated. Don't worry about merge conflicts here: I'm not far enough along for them to be a big deal at the moment (especially because resolving them will simply be "use my changes instead"). I up to you two I guess. Probably not needed as these will be automatic soon, but doesn't hurt to temporarily have in case there's a new brew release before I get those completions working. Does that give you enough to go on or do you want me to make the decision? |
MikeMcQuaid
approved these changes
Jan 20, 2021
Member
|
Thanks again @hyuraku! |
cb592ae to
7e2db0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?add cask options to commands( reinstall and upgrade ) in zsh/completions.