Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocops: Permit uses_from_macos "cyrus-sasl" #10808

Merged
merged 1 commit into from Mar 10, 2021
Merged

rubocops: Permit uses_from_macos "cyrus-sasl" #10808

merged 1 commit into from Mar 10, 2021

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Mar 8, 2021 •
edited

macOS provides /usr/lib/libsasl2.dylib

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

macOS Catalina 10.15 provides /usr/lib/libsasl2.dylib. I have not checked other versions of macOS.
See the companion PR Homebrew/homebrew-core#72759 cyrus-sasl 2.1.27 (new formula)

@sjackman sjackman self-assigned this Mar 8, 2021
@BrewTestBot
Copy link
Member

Review period will end on 2021-03-09 at 23:15:46 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 8, 2021
@sjackman sjackman enabled auto-merge March 8, 2021 23:27
@sjackman
Copy link
Member Author

sjackman commented Mar 9, 2021 

1st Try error in ./test/support/helper/spec/shared_examples/formulae_exist.rb:6:
Error: RuboCop::Cop::FormulaAudit::ProvidedByMacos libsasl2 formula exists

https://github.com/Homebrew/brew/pull/10808/checks?check_run_id=2061171033#step:14:46

@sjackman sjackman changed the title rubocops: Permit uses_from_macos "libsasl2" rubocops: Permit uses_from_macos "cyrus-sasl" Mar 9, 2021
@sjackman sjackman mentioned this pull request Mar 9, 2021
Closed
5 tasks
@sjackman sjackman force-pushed the sj/uses-from-macos-libsasl2 branch from 6dcf4e7 to 8f13fd2 Compare March 9, 2021 01:28
@iMichka iMichka mentioned this pull request Mar 9, 2021
Closed
5 tasks
iMichka
iMichka requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debian calls this libsasl2, so let's just discuss the name first.

iMichka
iMichka approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the name.

@EricFromCanada
Copy link
Member

/usr/lib/libsasl2.dylib is available since at least OS X 10.10.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 10, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@sjackman sjackman force-pushed the sj/uses-from-macos-libsasl2 branch from 8f13fd2 to 015e27c Compare March 10, 2021 00:54
@sjackman sjackman added the critical Critical change which should be shipped as soon as possible. label Mar 10, 2021
@carlocab carlocab mentioned this pull request Mar 10, 2021
Closed
@sjackman sjackman removed the critical Critical change which should be shipped as soon as possible. label Mar 10, 2021
@sjackman
Copy link
Member Author

This PR is gated on cyrus-sasl being added to Linuxbrew-core. cyrus-sasl has been added to Homebrew-core.

@sjackman
rubocops: Permit uses_from_macos "cyrus-sasl"
0bba3bc 
macOS provides /usr/lib/libsasl2.dylib
@sjackman sjackman force-pushed the sj/uses-from-macos-libsasl2 branch from 015e27c to 0bba3bc Compare March 10, 2021 16:16
@sjackman sjackman merged commit 4524714 into Homebrew:master Mar 10, 2021
@sjackman sjackman deleted the sj/uses-from-macos-libsasl2 branch March 10, 2021 17:07
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@iMichka iMichka iMichka approved these changes

@carlocab carlocab carlocab approved these changes

@danielnachun danielnachun Awaiting requested review from danielnachun

@dawidd6 dawidd6 Awaiting requested review from dawidd6

Assignees

@sjackman sjackman

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sjackman @BrewTestBot @EricFromCanada @MikeMcQuaid @iMichka @carlocab