Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying timeouts for commands and downloads. #10864

Merged
merged 1 commit into from Mar 18, 2021
Merged

Allow specifying timeouts for commands and downloads. #10864

merged 1 commit into from Mar 18, 2021

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 16, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Needed for https://github.com/Homebrew/brew/pulls.

@BrewTestBot
Copy link
Member

Review period will end on 2021-03-17 at 17:15:45 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 16, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 17, 2021
samford
samford approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to replicate the hang with my Utils::Curl/Livecheck::Strategy changes for a couple weeks but I did comparative test runs across homebrew/core with/without the timeout changes and didn't see any issues. In general, this looks good to me. Thanks, @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit d55bdd3 into Homebrew:master Mar 18, 2021
@MikeMcQuaid
Copy link
Member

Thanks @reitermarkus!

This was referenced Mar 24, 2021
Closed
Merged
Rylan12 added a commit to Rylan12/brew that referenced this pull request Mar 24, 2021
@Rylan12
Revert "Merge pull request Homebrew#10864 from reitermarkus/command-t…
57b2660 
…imeout"

This reverts commit d55bdd3, reversing
changes made to 3c3bf1c.
reitermarkus added a commit to reitermarkus/brew that referenced this pull request Apr 3, 2021
@reitermarkus
Revert "Revert "Merge pull request Homebrew#10864 from reitermarkus/c…
24c9b59 
…ommand-timeout""

This reverts commit 57b2660.
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@samford samford samford approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@reitermarkus @BrewTestBot @MikeMcQuaid @jayzalowitz @Bo98 @samford @Rylan12