Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore timeout when checking for HTTPS availability. #10898

Merged
merged 2 commits into from Mar 22, 2021
Merged

Ignore timeout when checking for HTTPS availability. #10898

merged 2 commits into from Mar 22, 2021

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 22, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes audit failing for URLs where HTTPS is not available.

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Mar 22, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@reitermarkus reitermarkus merged commit 6eaeba1 into Homebrew:master Mar 22, 2021
@reitermarkus reitermarkus deleted the audit-timeout branch March 22, 2021 23:58
This was referenced Mar 24, 2021
Closed
Merged
Rylan12 added a commit to Rylan12/brew that referenced this pull request Mar 24, 2021
@Rylan12
Revert "Merge pull request Homebrew#10898 from reitermarkus/audit-tim…
0b8a9bc 
…eout"

This reverts commit 6eaeba1, reversing
changes made to 28b1765.
reitermarkus added a commit to reitermarkus/brew that referenced this pull request Apr 3, 2021
@reitermarkus
Revert "Revert "Merge pull request Homebrew#10898 from reitermarkus/a…
cdcd216 
…udit-timeout""

This reverts commit 0b8a9bc.
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @BrewTestBot @MikeMcQuaid