Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Packages Tab download #10977

Merged

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Mar 31, 2021

  • Simplify and improve the GitHub Packages bottle download logic to be more idiomatic (and allow easier removal if GitHub ever drops the special header requirement).
  • Make use of the tabs uploaded to GitHub Packages manifests by downloading, parsing and installing them (based on the bottle checksum). This will allow adding brew bottle --only-json-tab in future to stop building tabs into our bottles (making them more reproducible as the e.g. timestamps in our current bottles guarantee non-reproducibility).

While we're here:

  • utils/bottles: remove unused method
  • download_strategy: fix whitespace.

For testing use HOMEBREW_BOTTLE_DOMAIN=https://ghcr.io/v2/Homebrew/core brew fetch git-delta and HOMEBREW_BOTTLE_DOMAIN=https://ghcr.io/v2/Homebrew/core brew reinstall git-delta.

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-01 at 19:33:08 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 31, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 31, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 31, 2021
@MikeMcQuaid MikeMcQuaid force-pushed the github_packages_tab_download branch 5 times, most recently from 5b63745 to fd32089 Compare March 31, 2021 20:13
@MikeMcQuaid MikeMcQuaid force-pushed the github_packages_tab_download branch 2 times, most recently from 61e249f to 7bb5b1c Compare April 1, 2021 08:53
@MikeMcQuaid MikeMcQuaid merged commit ab0d9f1 into Homebrew:master Apr 2, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label May 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
@MikeMcQuaid MikeMcQuaid deleted the github_packages_tab_download branch February 22, 2023 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants