Use GITHUB_TOKEN more consistently. #11043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
previously approved these changes
Apr 6, 2021
reitermarkus
reviewed
Apr 6, 2021
reitermarkus
reviewed
Apr 6, 2021
dawidd6
reviewed
Apr 6, 2021
reitermarkus
reviewed
Apr 6, 2021
MikeMcQuaid
force-pushed
the
tokens_cleanup
branch
from
bde0263
to
3777a96
Compare
BrewTestBot
previously approved these changes
Apr 6, 2021
https://docs.github.com/en/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token This provides enough permissions for almost everything we want to do. When it's not enough (e.g. for `brew update-maintainers`): generate a dedicated, repo-specific token for when increased scopes are needed and setup a new organisation-wide token on the new PAT format.
MikeMcQuaid
force-pushed
the
tokens_cleanup
branch
from
3777a96
to
d837d5c
Compare
BrewTestBot
approved these changes
Apr 6, 2021
dawidd6
approved these changes
Apr 6, 2021
Bo98
reviewed
Apr 6, 2021
| repo-token: ${{ secrets.HOMEBREW_GITHUB_API_TOKEN }} | ||
| repo-token: ${{ secrets.HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN }} |
There was a problem hiding this comment.
# This file is synced from the '.github' repository, do not modify it directly.
There was a problem hiding this comment.
Oops, addressing in Homebrew/.github#14
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token
This provides enough permissions for almost everything we want to do.
When it's not enough (e.g. for
brew update-maintainers): generate a dedicated, repo-specific token for when increased scopes are needed and setup a new organisation-wide token on the new PAT format.This may well break things. If so: please do not revert this PR but specifically revert the workflow(s) token changes that are failing.