Formula#bottle_hash: various fixes/updates.
#11088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
MikeMcQuaid
changed the title
Formula#bottle_hash: various fixes/updates.
BrewTestBot
previously approved these changes
Apr 9, 2021
BrewTestBot
previously approved these changes
Apr 9, 2021
Bo98
previously approved these changes
Apr 9, 2021
It's dramatically more human readable for very little difference in space.
- remove `cellar` because it's no longer global - remove `prefix` because it's no longer customisable - add `cellar` for each bottle tag - fix `url` for GitHub Packages
MikeMcQuaid
removed
the
critical
MikeMcQuaid
requested review from
BrewTestBot
and removed request for
BrewTestBot
|
Review period will end on 2021-04-12 at 13:08:31 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cellarbecause it's no longer globalprefixbecause it's no longer customisablecellarfor each bottle tagurlfor GitHub Packages. This will fix the formulae.brew.sh URLs being broken (https://formulae.brew.sh/api/formula/hello.json)While we're here:
JSON.pretty_generateglobally as it's dramatically more human readable for very little difference in space (and we've used it a few other places already)