Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle: no need to set cellar anymore #11099

Merged
merged 1 commit into from Apr 10, 2021
Merged

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Apr 9, 2021

Fixes:
Calling cellar in a bottle block is deprecated! Use brew style --fix on the formula to update the style or use sha256 with a cellar: argument instead.

Fix the error message:
brew style --fix does nothing for this issue

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-12 at 21:21:52 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 9, 2021
@iMichka iMichka requested a review from Bo98 April 9, 2021 21:22
@iMichka
Copy link
Member Author

iMichka commented Apr 9, 2021

I hope this fixes the issue, as I was not able to reproduce it locally.

@iMichka iMichka added the critical Critical change which should be shipped as soon as possible. label Apr 9, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 9, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

BrewTestBot
BrewTestBot previously approved these changes Apr 9, 2021
BrewTestBot
BrewTestBot previously approved these changes Apr 9, 2021
dawidd6
dawidd6 previously approved these changes Apr 9, 2021
@Bo98
Copy link
Member

Bo98 commented Apr 9, 2021

brew style --fix should work for old formulae - it didn’t for this case because it wasn’t intended that there was bugs like this.

Fixes:
Calling `cellar` in a bottle block is deprecated! Use `brew style --fix` on the formula to update the style or use `sha256` with a `cellar:` argument instead.
@iMichka
Copy link
Member Author

iMichka commented Apr 10, 2021

I added the "brew fix" line back.

@iMichka iMichka merged commit 6359af5 into Homebrew:master Apr 10, 2021
@iMichka iMichka deleted the bottle branch April 10, 2021 08:26
@github-actions github-actions bot added the outdated PR was locked due to age label May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants