-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit: make sure service commands exist #11129
Audit: make sure service commands exist #11129
Conversation
Review period will end on 2021-04-14 at 09:26:43 UTC. |
281dacd
to
a8839da
Compare
And here we have 1 of the 2 reasons that I wanted to make the service block. |
Hmm, I need to somehow make this audit require an installed formula. Any suggestions? |
brew/Library/Homebrew/formula_cellar_checks.rb Lines 278 to 297 in a4ea7fb
|
It seems kinda weird to add it to the Cellar checks since it checks the formula, not the cellar. But I guess that can work until someone has a better idea. |
You can think of it as checking the Cellar that the file referenced by the service block exists. |
Review period ended. |
a8839da
to
ed0804d
Compare
ed0804d
to
2a4d0b0
Compare
2a4d0b0
to
f9ea99e
Compare
f9ea99e
to
9e826bb
Compare
9e826bb
to
4c0a782
Compare
4c0a782
to
6c8c707
Compare
6c8c707
to
73e597a
Compare
73e597a
to
52f4046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One question if you don't mind: why/when/how would you specify multiple run
commands?
It's multiple parts, e.g. |
Ah gotcha, thanks! |
88afa58
to
2ec4125
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?