Audit: make sure service commands exist

[SMillerDev]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[BrewTestBot]

Review period will end on 2021-04-14 at 09:26:43 UTC.

[SMillerDev]

And here we have 1 of the 2 reasons that I wanted to make the service block.

[SMillerDev]

Hmm, I need to somehow make this audit require an installed formula. Any suggestions?

[MikeMcQuaid]

Hmm, I need to somehow make this audit require an installed formula. Any suggestions?

brew/Library/Homebrew/formula_cellar_checks.rb

Lines 278 to 297 in a4ea7fb

	def audit_installed
	@new_formula ||= false
	problem_if_output(check_manpages)
	problem_if_output(check_infopages)
	problem_if_output(check_jars)
	problem_if_output(check_non_libraries) if @new_formula
	problem_if_output(check_non_executables(formula.bin))
	problem_if_output(check_generic_executables(formula.bin))
	problem_if_output(check_non_executables(formula.sbin))
	problem_if_output(check_generic_executables(formula.sbin))
	problem_if_output(check_easy_install_pth(formula.lib))
	problem_if_output(check_elisp_dirname(formula.share, formula.name))
	problem_if_output(check_elisp_root(formula.share, formula.name))
	problem_if_output(check_python_packages(formula.lib, formula.deps))
	problem_if_output(check_shim_references(formula.prefix))
	problem_if_output(check_plist(formula.prefix, formula.plist))
	problem_if_output(check_python_symlinks(formula.name, formula.keg_only?))
	end
	alias generic_audit_installed audit_installed

[SMillerDev]

It seems kinda weird to add it to the Cellar checks since it checks the formula, not the cellar. But I guess that can work until someone has a better idea.

[Bo98]

It seems kinda weird to add it to the Cellar checks since it checks the formula, not the cellar. But I guess that can work until someone has a better idea.

You can think of it as checking the Cellar that the file referenced by the service block exists.

[BrewTestBot]

Review period ended.

[Rylan12]

Looks good to me. One question if you don't mind: why/when/how would you specify multiple run commands?

[SMillerDev]

Looks good to me. One question if you don't mind: why/when/how would you specify multiple run commands?

It's multiple parts, e.g. [bin/'httpd', '-D', 'foreground']

[Rylan12]

Ah gotcha, thanks!