Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend/os/mac/keg_relocate: remove HOMEBREW_RELOCATE_METAVARS #11370

Merged
merged 1 commit into from May 13, 2021

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally? -- SystemCommand#run failure

It's not being used, and it breaks formulae when it is.

Plus do some extra refactoring.

It's not being used, and it breaks formulae when it is.

Plus do some extra refactoring.
@carlocab carlocab requested a review from sjackman May 12, 2021 03:40
@BrewTestBot
Copy link
Member

Review period will end on 2021-05-13 at 03:39:58 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 12, 2021
@carlocab carlocab enabled auto-merge May 12, 2021 08:41
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label May 13, 2021
@carlocab carlocab merged commit dd19990 into Homebrew:master May 13, 2021
@carlocab carlocab deleted the relocate-metavars branch May 13, 2021 11:25
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants