diagnostic: add check for broken taps #11473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2021-06-01 at 17:12:08 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
reviewed
Jun 1, 2021
Detect half-baked core taps that show up on a fairly regular basis (e.g. Homebrew#11465). The logic is simple enough: Since an improper tap wouldn't have a complete Git config, and is always somewhere below `HOMEBREW_REPOSITORY`, any Git operation would look at the Brew repo instead. We simply need to test for any of: 1. Empty tap origin 2. Empty tap HEAD 3. Tap HEAD == Brew HEAD
gromgit
force-pushed
the
diagnose-broken-tap
branch
from
c6b1019
to
c7bbb90
Compare
|
@MikeMcQuaid, thanks much for the comprehensive review! I've refactored my changes based on your last comment:
It's certainly more streamlined now. 😁 |
MikeMcQuaid
reviewed
Jun 1, 2021
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
gromgit
force-pushed
the
diagnose-broken-tap
branch
from
bf71a5f
to
1cf8b43
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Jun 1, 2021
MikeMcQuaid
approved these changes
Jun 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect half-baked core taps that show up on a fairly regular basis (e.g. #11465, #11243).
A half-baked tap wouldn't have a complete Git config, and is always somewhere below
HOMEBREW_REPOSITORY, so any Git operation would refer to the Brew repo instead. We simply need to test for any of:brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?