Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rubocop-rspec from 2.3.0 to 2.4.0 in /Library/Homebrew #11519

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2021

Bumps rubocop-rspec from 2.3.0 to 2.4.0.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.4.0

  • Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). (@​topalovic)
  • Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. (@​tejasbubane)
  • Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. (@​rrosenblum)
  • Add new RSpec/IdenticalEqualityAssertion cop. (@​tejasbubane)
  • Add RSpec/Rails/AvoidSetupHook cop. (@​paydaylight)
  • Fix false negative in RSpec/ExpectChange cop with block style and chained method call. (@​tejasbubane)
Changelog

Sourced from rubocop-rspec's changelog.

2.4.0 (2021-06-09)

  • Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). ([@​topalovic][])
  • Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. ([@​tejasbubane][])
  • Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. ([@​rrosenblum][])
  • Add new RSpec/IdenticalEqualityAssertion cop. ([@​tejasbubane][])
  • Add RSpec/Rails/AvoidSetupHook cop. ([@​paydaylight][])
  • Fix false negative in RSpec/ExpectChange cop with block style and chained method call. ([@​tejasbubane][])
Commits
  • 1b360e5 Merge pull request #1159 from rubocop/release
  • b82febd Bump version to 2.4.0
  • 2d00dbb Merge pull request #1158 from topalovic/file-path-check-suffix-for-non-const
  • c4646ff Make FilePath check suffix when given a non-const top-level node
  • 0be6148 Merge pull request #1152 from tejasbubane/fix-1143
  • 0cbc140 Add more specs for RSpec/ExpectChange
  • c3dd64a Fix false negative in RSpec/ExpectChange cop with block style and chained m...
  • 9e55194 Merge pull request #1133 from paydaylight/add-prefer-before-over-setup-cop
  • e94b463 Add RSpec/Rails/AvoidSetupHook cop
  • e0e109c Merge pull request #1132 from tejasbubane/fix-1130
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Jun 10, 2021
@nandahkrishna
Copy link
Member

@dependabot recreate

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/Library/Homebrew/rubocop-rspec-2.4.0 branch from 1828a16 to a611926 Compare June 10, 2021 07:42
@nandahkrishna
Copy link
Member

We had this in a test, I believe intentionally:

expect(described_class.parse("1.0_1")).to be == described_class.parse("1.0_1")

Due to the style error being raised, I changed this to:

version_to_compare = described_class.parse("1.0_1")
expect(version_to_compare == described_class.parse("1.0_1")).to be true
expect(version_to_compare == described_class.parse("1.0_2")).to be false

Not sure if this is correct, so please feel free to edit/change this.

@MikeMcQuaid MikeMcQuaid merged commit 33e71c9 into master Jun 10, 2021
@MikeMcQuaid MikeMcQuaid deleted the dependabot/bundler/Library/Homebrew/rubocop-rspec-2.4.0 branch June 10, 2021 11:25
@MikeMcQuaid
Copy link
Member

Thanks @nandahkrishna!

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants