New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixtures: add test.epub #11646
fixtures: add test.epub #11646
Conversation
Review period will end on 2021-07-06 at 00:00:00 UTC. |
@chenrui333 Thanks for this! How many formulae would this be for? Is this the smallest possible valid |
I did not count the formulae, as epub is a very popular book format, it would be very beneficial to add this.
Yes, this is 3.76kb smallest epub (content is |
Review period ended. |
Could content be e.g.
I'd like to see 5+ formulae that need this before we add a multikilobyte fixture. |
Sure, I will simplify the test to just one char in the content
Currently, we only have four formulae in the core can benefit from this fixture.
|
@chenrui333 Cool, I'm fine given those four formulae. Can you squash your commits? Thanks! |
Sure, sounds good. :) |
Signed-off-by: Rui Chen <rui@chenrui.dev>
Thanks @chenrui333! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Addding a test epub to test epub related formulae.