Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixtures: add test.epub #11646

Merged
merged 1 commit into from Jul 9, 2021
Merged

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jul 3, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Addding a test epub to test epub related formulae.

@BrewTestBot
Copy link
Member

Review period will end on 2021-07-06 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 3, 2021
@MikeMcQuaid
Copy link
Member

@chenrui333 Thanks for this! How many formulae would this be for? Is this the smallest possible valid .epub file?

@chenrui333
Copy link
Member Author

chenrui333 commented Jul 5, 2021

@chenrui333 Thanks for this! How many formulae would this be for?

I did not count the formulae, as epub is a very popular book format, it would be very beneficial to add this.

Is this the smallest possible valid .epub file?

Yes, this is 3.76kb smallest epub (content is Homebrew test)

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 6, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid
Copy link
Member

Yes, this is 3.76kb smallest epub (content is Homebrew test)

Could content be e.g. b instead?

I did not count the formulae, as epub is a very popular book format, it would be very beneficial to add this.

I'd like to see 5+ formulae that need this before we add a multikilobyte fixture.

@chenrui333
Copy link
Member Author

Could content be e.g. b instead?

Sure, I will simplify the test to just one char in the content

I did not count the formulae, as epub is a very popular book format, it would be very beneficial to add this.

Currently, we only have four formulae in the core can benefit from this fixture.

  • docbook-xsl
  • epr
  • epubcheck
  • kepubify

@MikeMcQuaid
Copy link
Member

@chenrui333 Cool, I'm fine given those four formulae. Can you squash your commits? Thanks!

@chenrui333
Copy link
Member Author

Sure, sounds good. :)

Signed-off-by: Rui Chen <rui@chenrui.dev>
@MikeMcQuaid MikeMcQuaid merged commit 5659d74 into Homebrew:master Jul 9, 2021
@MikeMcQuaid
Copy link
Member

Thanks @chenrui333!

@chenrui333 chenrui333 deleted the add-test-epub branch July 28, 2021 18:03
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants