Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula: add a time method for use as the build time #11659

Merged
merged 1 commit into from Jul 7, 2021
Merged

formula: add a time method for use as the build time #11659

merged 1 commit into from Jul 7, 2021

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jul 6, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A number of formulae use a variant of Time.now to generate the build
time of the formula. Let's define a method to make sure that:

  1. it uses SOURCE_DATE_EPOCH whenever available; and,
  2. it uses utc.

Both should help with build reproducibility.

See Homebrew/homebrew-core#80608.

@carlocab
formula: add a time method for use as the build time
3776ba9 
A number of formulae use a variant of `Time.now` to generate the build
time of the formula. Let's define a method to make sure that:

1. it uses `SOURCE_DATE_EPOCH` whenever available; and,
2. it uses `utc`.

Both should help with build reproducibility.

See Homebrew/homebrew-core#80608.
@BrewTestBot
Copy link
Member

Review period will end on 2021-07-07 at 11:29:24 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 6, 2021
@carlocab carlocab mentioned this pull request Jul 6, 2021
Closed
6 tasks
MikeMcQuaid
MikeMcQuaid approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@carlocab carlocab enabled auto-merge July 6, 2021 12:46
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 7, 2021
@carlocab carlocab merged commit 7c2a8f6 into Homebrew:master Jul 7, 2021
@carlocab carlocab deleted the time branch July 7, 2021 13:16
@bayandin bayandin mentioned this pull request Jul 8, 2021
Closed
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlocab @BrewTestBot @MikeMcQuaid @SMillerDev