Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_installer: install service after linking #11777

Merged
merged 1 commit into from Jul 26, 2021
Merged

formula_installer: install service after linking #11777

merged 1 commit into from Jul 26, 2021

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix the issue created in #11772

@SMillerDev SMillerDev added the critical Critical change which should be shipped as soon as possible. label Jul 26, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@dawidd6 dawidd6 merged commit 3e52e8b into Homebrew:master Jul 26, 2021
@carlocab
Copy link
Member

This needs to be tagged. I have a draft, but need someone with admin access to publish it: https://github.com/Homebrew/brew/releases/tag/untagged-734b2576bcf49c29271c

CC @Homebrew/plc @Homebrew/tsc

@carlocab
Copy link
Member

Fixed. Thanks @iMichka.

@carlocab carlocab mentioned this pull request Jul 27, 2021
Closed
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
@SMillerDev SMillerDev deleted the fix/service/pre_link_error branch September 21, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SMillerDev @BrewTestBot @carlocab @dawidd6