Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.17rc - testing only #81919

Closed
wants to merge 9 commits into from
Closed

go 1.17rc - testing only #81919

wants to merge 9 commits into from

Conversation

andig
Copy link
Contributor

@andig andig commented Jul 26, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

Testing PR to see how far we can get with go 1.17 as discussed on Homebrew/discussions#1889 (comment)

Created using:

brew bump-formula-pr golang --version 1.17rc1 --force --no-audit

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 26, 2021
@andig andig changed the title go 1.17rc1 go 1.17rc1 - testing only Jul 26, 2021
@andig andig marked this pull request as draft July 26, 2021 10:28
@SMillerDev SMillerDev added upstream issue An upstream issue report is needed prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies and removed upstream issue An upstream issue report is needed labels Jul 26, 2021
Formula/go.rb Outdated Show resolved Hide resolved
@andig
Copy link
Contributor Author

andig commented Jul 26, 2021

Still no:

Stable version URLs should not contain rc1

@andig
Copy link
Contributor Author

andig commented Jul 26, 2021

Wow- looks as if CI is actually passing this time? In this case I'd suggest to keep the PR open and update on release or just close it and go through regular bump-formula on release.

Would replace #81824, too.

@carlocab carlocab added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 26, 2021
@andig
Copy link
Contributor Author

andig commented Jul 27, 2021

I have not looked through all of the errors, but there is a number of:

  • Error: dep: no bottle available: not sure what to do here. Raise upstream issues for each occurrence or deprecate the formula? Imho- if repo has not upgraded to go modules yet it is a good indication that the project is inactive?
  • Downloading/ Already downloaded/ Failed to install service files: what are these? Seem to be happening independentely from any compile errors?
  • Some unexpected go version due to the rc, these should vanish with go final

@andig
Copy link
Contributor Author

andig commented Jul 27, 2021

@carlocab
Copy link
Member

Failed to install service files should've been fixed in Homebrew/brew#11777. We could probably re-run CI to make sure.

@andig
Copy link
Contributor Author

andig commented Jul 28, 2021

We could probably re-run CI to make sure.

could we do that to get rid of the spurious errors? I can compile a full tasklist afterwards.

@carlocab
Copy link
Member

CI isn't running for some reason. Let's try to get this going again...

@andig
Copy link
Contributor Author

andig commented Jul 29, 2021

Quick analysis. There are test failures:

  • akamai
  • awsweeper
  • bitrise
  • darksky-weather
  • func-e
  • ooniprobe
  • server-go
  • storj-uplink
  • tunnel
  • xray

dep deprecations:

and finally SHA mismatches:

  • baidupcs-go
  • convox
  • helmfile
  • logcli logcli 2.3.0 #82894
  • promtail -> already resolved by 2.4.0 bump?

@andig
Copy link
Contributor Author

andig commented Jul 29, 2021

I will open deprecation PRs for anything using dep. These repos have not seen updates for >2 to 6 years.

BHPettersen
BHPettersen previously approved these changes Jul 31, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 3, 2021
@carlocab carlocab added in progress Stale bot should stay away help wanted Task(s) needing PRs from the community or maintainers and removed stale No recent activity labels Aug 3, 2021
@branchvincent
Copy link
Member

logcli will be fixed by a new version #82894

@andig
Copy link
Contributor Author

andig commented Aug 7, 2021

Can we get the dep deprecations merged?

Formula/go.rb Outdated Show resolved Hide resolved
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@andig
Copy link
Contributor Author

andig commented Aug 10, 2021

We're 8 days away from the planned go 1.17 release. How shall we proceed with the SHA mismatches and test errors?

Update since the has been a couple of bumps in the meantime, would it be worth restarting CI?

@andig andig changed the title go 1.17rc1 - testing only go 1.17rc - testing only Aug 10, 2021
@andig
Copy link
Contributor Author

andig commented Aug 16, 2021

Clsing in favor of 1.17 final

@andig andig closed this Aug 16, 2021
@cho-m cho-m added superseded PR was replaced by another PR and removed help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away labels Aug 16, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants