Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "formula: remove OnOS." #12925

Merged
merged 2 commits into from Feb 24, 2022
Merged

Revert "formula: remove OnOS." #12925

merged 2 commits into from Feb 24, 2022

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Feb 24, 2022 •
edited

Reverts #12912

CC @carlocab FYI

We still need this for e.g. test do blocks.

@BrewTestBot
Copy link
Member

Review period will end on 2022-02-25 at 12:31:52 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 24, 2022
@MikeMcQuaid
formula: remove OnOS deprecation comment.
20f2b14 
We can't actually remove this as we still need it indefinitely in e.g. `def caveats`.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 24, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 24, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 7735947 into master Feb 24, 2022
@MikeMcQuaid MikeMcQuaid deleted the revert-12912-formula_remove_include_on_os branch February 24, 2022 12:51
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @BrewTestBot @carlocab