Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Service#keep_alive? method #12988

Merged
merged 1 commit into from Mar 14, 2022
Merged

Conversation

apainintheneck
Copy link
Contributor

  • [ x] Have you followed the guidelines in our Contributing document?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ x] Have you written new tests for your changes? Here's an example.
  • [ x] Have you successfully run brew style with your changes locally?
  • [ x] Have you successfully run brew typecheck with your changes locally?
  • [ x] Have you successfully run brew tests with your changes locally?

This PR is related to the kill command that I'm currently working on adding to brew services (over here). As a part of that I'd like to be able to see if a service has been marked as keep_alive. Currently, there is only a setter for that in the Service class so I added a getter.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit fbc5b11 into Homebrew:master Mar 14, 2022
@apainintheneck apainintheneck deleted the add_keep_alive branch March 14, 2022 23:07
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants