service: add sockets and keepalive variants

[SMillerDev]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This adds the last remaining features to services before we can deprecate plist usage.

[BrewTestBot]

Review period will end on 2022-01-26 at 18:30:16 UTC.

[SMillerDev]

See Homebrew/homebrew-core#93612

[MikeMcQuaid]

Looks good so far!

How many plists still need ported in homebrew-core?

[SMillerDev]

These would be the last ones that aren't deprecated.

[BrewTestBot]

Review period ended.

[Bo98]

Just realised that I maybe should have held merging #12988 as I'm not sure how it would work API wise with what you're doing here.

(Though the API can change until a new release is tagged - and I'll hold off doing so today.)

Maybe it's fine - I'm guessing the change would be it would take a parameter for the "type" and it could default to always to allow a no-arg call, unless we want to enforce always specifying the type.

[SMillerDev]

I already spotted the services part of that PR and it's fine.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[SMillerDev]

Okay, this is ready for another round now

[MikeMcQuaid]

Suggested change

	if @keep_alive[:always].present?
	base[:KeepAlive] = @keep_alive[:always]
	elsif @keep_alive.key? :succesful_exit
	base[:KeepAlive] = { SuccessfulExit: @keep_alive[:succesful_exit] }
	elsif @keep_alive.key? :crashed
	base[:KeepAlive] = { Crashed: @keep_alive[:crashed] }
	elsif @keep_alive.key? :path
	base[:KeepAlive] = { PathState: @keep_alive[:path].to_s }
	end
	if (always = @keep_alive[:always].presence)
	base[:KeepAlive] = always
	elsif @keep_alive.key?(:successful_exit)
	base[:KeepAlive] = { SuccessfulExit: @keep_alive[:succesful_exit] }
	elsif @keep_alive.key?(:crashed)
	base[:KeepAlive] = { Crashed: @keep_alive[:crashed] }
	elsif @keep_alive.key?(:path)
	base[:KeepAlive] = { PathState: @keep_alive[:path].to_s }
	end

which of these keys are you still going to set if they are either false or nil (separate questions)?

[SMillerDev]

All except path for false, for nil I doubt there is a use.

[SMillerDev]

Any remaining comments based on this?

[MikeMcQuaid]

Nah, find as-is.