docs: add automatic listing of governance archives #13185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-04-26 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
reviewed
Apr 25, 2022
EricFromCanada
force-pushed
the
governance-archives-listing
branch
2 times, most recently
from
ccb90b9
to
35a1dd3
Compare
MikeMcQuaid
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Fine with or without optional change, nice work here as usual @EricFromCanada!
docs/README.md
Outdated
| @@ -74,3 +74,4 @@ | |||
|
|
|||
| - [Homebrew Governance](Homebrew-Governance.md) | |||
| - [Homebrew Leadership Responsibilities](Homebrew-Leadership-Responsibilities.md) | |||
| - [Homebrew Governance Archives](Governance-Archives.md) | |||
There was a problem hiding this comment.
Suggested change
| - [Homebrew Governance Archives](Governance-Archives.md) | |
| - [Homebrew Governance Archives](Homebrew-Governance-Archives.md) |
for pedantic consistency? I'm sorry 😂
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Apr 26, 2022
ARREOLACAR
referenced
this pull request
Apr 26, 2022
- Without this, vale won't correctly detect where the styles are.
EricFromCanada
force-pushed
the
governance-archives-listing
branch
from
35a1dd3
to
b22b413
Compare
MikeMcQuaid
approved these changes
May 2, 2022
|
Thanks again @EricFromCanada! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?With this, any .md files added to the "governance" folder will be linked from /Governance-Archives.
I'd originally planned to implement the listing as a Jekyll collection, but doing so would have required each file to have empty front matter because the
jekyll-optional-front-matterplugin currently does not apply to collections. What this does instead is automatically add a category to each page in the folder and iterate through each categorized page.