Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: even more precise tag replacement #13597

Merged
merged 1 commit into from Jul 25, 2022

Conversation

bayandin
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If in a formula tag matches version, then bump-formula-pr with --version argument fails:

% brew bump-formula-pr --version 2022-07-22  --debug exploitdb              
...
==> replace /2022-07-12(?=")/ with "2022-07-22"
==> replace "d84f857e94f91c71fcb93041483f661d29023c1e" with "46346f8944f5d01e09a8ed3d78e34cf759697b47"
==> replace "version \"2022-07-12\"" with "version \"2022-07-22\""
Error: inreplace failed
/opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/exploitdb.rb:
  expected replacement of "version \"2022-07-12\"" with "version \"2022-07-22\""
/opt/homebrew/Library/Homebrew/utils/inreplace.rb:89:in `inreplace_pairs'
/opt/homebrew/Library/Homebrew/dev-cmd/bump-formula-pr.rb:311:in `bump_formula_pr'
/opt/homebrew/Library/Homebrew/brew.rb:93:in `<main>'

Version got replaced by the first replacement pair (for the tag), and it failed to be replaced on the third one (for version).

Closes #13596

@BrewTestBot
Copy link
Member

Review period will end on 2022-07-25 at 13:28:24 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 22, 2022
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Jul 25, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@bayandin bayandin merged commit 864f1be into Homebrew:master Jul 25, 2022
@bayandin bayandin deleted the bayandin-patch-1 branch July 25, 2022 16:30
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew bump can fail on some forms of replacements
3 participants