Changes to allow keg-only glibc #13873

Bo98 · 2022-09-15T13:16:48Z

Not tested yet.

See Homebrew/homebrew-core#109998 and Homebrew/homebrew-core#110779, the latter of which is what the install changes are based on.

If it works, it'll need to be merged at the same time as Homebrew/homebrew-core#109998 (if the change moving glibc to keg-only is made).

BrewTestBot · 2022-09-15T13:17:05Z

Review period will end on 2022-09-16 at 13:16:48 UTC.

MikeMcQuaid

Makes sense to me!

danielnachun · 2022-09-15T17:01:57Z

Do we also need to make sure the path to the glibc headers is added to the include paths?

Bo98 · 2022-09-15T17:09:43Z

I think our GCC handles that. I don't know about LLVM though.

I guess if we're adding it as a dependency everywhere, it might already be added like other dependencies are (so maybe the PATH change isn't needed...). Really the correct way would probably be how we handle glibc@2.13, but it seems like we've got away so far without.

Library/Homebrew/extend/os/linux/install.rb

carlocab · 2022-09-16T08:56:14Z

Library/Homebrew/extend/os/linux/install.rb

+        if ld_so.readable?
+          # Remove legacy symlinks
+          FileUtils.rm gcc_library_symlink if gcc_library_symlink.symlink?
+        else


Given that glibc will be keg-only:

I wonder if we should just keep using our glibc even if the host's is newer.

This will allow us to get rid of these GCC library symlinks entirely.

I wonder if we should just keep using our glibc even if the host's is newer.

Are you saying 1) "we should use it even if the host's is newer" or 2) "we should not use it even if the host's is newer"?

Personally, I'm in strongly in favour of 2) and moderately strongly opposed to 1).

It's actually neither; apologies for being unclear.

This else bit I'm commenting on above is the only part that keeps these GCC library symlinks around. This handles the case where the host Glibc is newer than ours, but the host GCC is older than our preferred version.

I was suggesting that for this case we should consider using a keg-only Glibc. I think that should allow us to get rid of these GCC symlinks entirely, which, based on previous discussion, was something we wanted to do but decided to punt on.

Whenever the host Glibc and host GCC are both not older, we should definitely not install the glibc formula.

This is a really interesting idea although @sjackman should comment when he is back on it as well. Using ldconfig as we are proposing to do would let us get rid of the GCC symlinks and hopefully move us closer towards getting rid of any use of -L#{HOMEBREW_PREFIX/}lib and -Wl,-rpath,#{HOMEBREW_PREFIX}/lib altogether.

move us closer towards getting rid of any use of -L#{HOMEBREW_PREFIX/}lib and -Wl,-rpath,#{HOMEBREW_PREFIX}/lib altogether.

Yes, I'd really like to be able to do this too.

Personal opinion is less people installing glibc the better, particularly when it comes to non-x86_64 platforms.

We don't support these. Let's not optimise for them at all until we have e.g. a means of generating portable Ruby there in CI.

Given I've not seen any objections, I'd like to merge this and Homebrew/homebrew-core#109998 as soon as today (after some testing) unless anyone is against that.

👍🏻 although I think binutils is as much if not more of a problem here.

👍🏻 although I think binutils is as much if not more of a problem here.

I'm not even sure why gcc@11 depends on binutils, tbh

Or any of the GCC formulae, for that matter

I'm not even sure why gcc@11 depends on binutils, tbh

@danielnachun Any ideas?

Possibly it's just there to make sure we also install brewed binutils when we install brewed gcc. If that's the case it could be changed to a global dependency. But we should make sure it's not needed for some other reason.

Possibly it's just there to make sure we also install brewed binutils when we install brewed gcc.

Why would we want to make sure of that?

BrewTestBot · 2022-09-16T15:02:11Z

Review period ended.

Library/Homebrew/extend/os/linux/install.rb

Bo98 · 2022-09-18T16:29:45Z

Library/Homebrew/extend/os/linux/install.rb

+        ld_gcc_conf = ld_so_conf_d/"50-homebrew-preferred-gcc.conf"
+        ld_gcc_conf.atomic_write <<~EOS
+          #{gcc_opt_prefix}/lib/gcc/#{GCC_VERSION_SUFFIX}
+        EOS


Not too critical: but I wonder whether we should be writing this everytime or only if it doesn't exist.

If the latter: what do we do if we want to update it in the future?

Library/Homebrew/extend/os/linux/development_tools.rb

Bo98 added the do not merge label Sep 15, 2022

BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 15, 2022

MikeMcQuaid approved these changes Sep 15, 2022

View reviewed changes

Bo98 force-pushed the glibc-keg-only branch 2 times, most recently from d234736 to f008d3e Compare September 15, 2022 13:34

XuehaiPan reviewed Sep 15, 2022

View reviewed changes

Library/Homebrew/extend/os/linux/install.rb Outdated Show resolved Hide resolved

XuehaiPan reviewed Sep 15, 2022

View reviewed changes

Library/Homebrew/extend/os/linux/install.rb Outdated Show resolved Hide resolved

Bo98 force-pushed the glibc-keg-only branch from f008d3e to 9dd82ad Compare September 16, 2022 00:41

carlocab reviewed Sep 16, 2022

View reviewed changes

Bo98 mentioned this pull request Sep 16, 2022

linuxbrew overrides some basic toolchain commands Homebrew/homebrew-core#110877

Closed

2 tasks

BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 16, 2022

BrewTestBot approved these changes Sep 16, 2022

View reviewed changes

carlocab approved these changes Sep 16, 2022

View reviewed changes

Library/Homebrew/extend/os/linux/install.rb Outdated Show resolved Hide resolved

Library/Homebrew/extend/os/linux/install.rb Outdated Show resolved Hide resolved

Bo98 commented Sep 18, 2022

View reviewed changes

Bo98 force-pushed the glibc-keg-only branch 4 times, most recently from 6eebf75 to fcdc376 Compare September 19, 2022 03:43

carlocab reviewed Sep 19, 2022

View reviewed changes

Library/Homebrew/extend/os/linux/development_tools.rb Outdated Show resolved Hide resolved

Bo98 force-pushed the glibc-keg-only branch from fcdc376 to 56eebb2 Compare September 19, 2022 04:06

XuehaiPan mentioned this pull request Sep 19, 2022

glibc: keg_only and optionally add system ld search paths Homebrew/homebrew-core#109998

Closed

6 tasks

Bo98 force-pushed the glibc-keg-only branch 2 times, most recently from 7545949 to 0633af0 Compare September 19, 2022 05:55

Bo98 added 3 commits September 19, 2022 07:06

extend/os/linux/install: use ld.so.conf.d where possible

07f5951

extend/os/linux/install: update old ld.so symlinks

88ca450

extend/os/linux/install: use arch-agnostic ld.so path

ae3c6a6

extend/os/linux/development_tools: consider keg-only glibc & binutils

a372ca6

Bo98 force-pushed the glibc-keg-only branch from 0633af0 to a372ca6 Compare September 19, 2022 06:06

Bo98 merged commit b8b195c into Homebrew:master Sep 19, 2022

Bo98 deleted the glibc-keg-only branch September 19, 2022 07:10

Bo98 removed the do not merge label Sep 19, 2022

This was referenced Sep 19, 2022

Having HOMEBREW_PREFIX/lib in LD_LIBRARY_PATH breaks things when glibc installed Homebrew/homebrew-core#109893

Closed

linux/diagnostic: check LD_LIBRARY_PATH when glibc is installed. #13826

Closed

github-actions bot added the outdated PR was locked due to age label Oct 20, 2022

github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to allow keg-only glibc #13873

Changes to allow keg-only glibc #13873

Bo98 commented Sep 15, 2022

BrewTestBot commented Sep 15, 2022

MikeMcQuaid left a comment

danielnachun commented Sep 15, 2022

Bo98 commented Sep 15, 2022 •

edited

carlocab Sep 16, 2022

MikeMcQuaid Sep 16, 2022

carlocab Sep 16, 2022 •

edited

danielnachun Sep 16, 2022

carlocab Sep 16, 2022

MikeMcQuaid Sep 16, 2022

carlocab Sep 16, 2022 •

edited

MikeMcQuaid Sep 18, 2022

danielnachun Sep 18, 2022

carlocab Sep 19, 2022

BrewTestBot commented Sep 16, 2022

Bo98 Sep 18, 2022

Changes to allow keg-only glibc #13873

Changes to allow keg-only glibc #13873

Conversation

Bo98 commented Sep 15, 2022

BrewTestBot commented Sep 15, 2022

MikeMcQuaid left a comment

Choose a reason for hiding this comment

danielnachun commented Sep 15, 2022

Bo98 commented Sep 15, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlocab Sep 16, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlocab Sep 16, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrewTestBot commented Sep 16, 2022

Choose a reason for hiding this comment

Bo98 commented Sep 15, 2022 •

edited

carlocab Sep 16, 2022 •

edited

carlocab Sep 16, 2022 •

edited