Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellenv: add explanatory MANPATH comment #13874

Merged
merged 1 commit into from Sep 15, 2022
Merged

shellenv: add explanatory MANPATH comment #13874

merged 1 commit into from Sep 15, 2022

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Sep 15, 2022

Resolves #13867 and (hopefully) future attempts to correct the intended functionality.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example. <added comment, no tests needed>
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally? <added comment, no typecheck needed>
  • Have you successfully run brew tests with your changes locally? <added comment, no tests needed>

@BrewTestBot
Copy link
Member

Review period will end on 2022-09-16 at 13:54:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 15, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 15, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 15, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! An optional improvement.

shellenv: add explanatory MANPATH comment
75c5769 
Resolves Homebrew#13867 and (hopefully) future attempts to correct the intended functionality.
@MikeMcQuaid MikeMcQuaid merged commit cd405c7 into Homebrew:master Sep 15, 2022
@MikeMcQuaid
Copy link
Member

Thanks @gromgit!

@gromgit gromgit deleted the shellenv/colon-comment branch September 15, 2022 16:24
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gromgit @BrewTestBot @MikeMcQuaid