Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend/ENV/std: ignore fails_with during brew test. #13913

Merged
merged 2 commits into from Sep 22, 2022

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The compiler used to a build a formula is typically not needed during
the test.

This will allow us to get rid of some :test dependencies, which were
added to prevent brew from throwing a CompilerSelectionError because
the formula declares fails_with the default compiler.

This also helps us get more accurate results from brew linkage in
cases of unintended linkage with the compiler used to build.

Fixes #11795.

The compiler used to a build a formula is typically not needed during
the test.

This will allow us to get rid of some `:test` dependencies, which were
added to prevent `brew` from throwing a `CompilerSelectionError` because
the formula declares `fails_with` the default compiler.

This also helps us get more accurate results from `brew linkage` in
cases of unintended linkage with the compiler used to build.

Fixes Homebrew#11795.
@carlocab carlocab requested review from Bo98 and cho-m September 21, 2022 14:57
@BrewTestBot
Copy link
Member

Review period will end on 2022-09-22 at 14:56:59 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 21, 2022
@carlocab
Copy link
Member Author

The compiler used to a build a formula is typically not needed during the test.

If it is still needed, the formula can declare the appropriate :test dependency and the compiler selection logic will still use the desired one.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

Library/Homebrew/extend/ENV/std.rb Outdated Show resolved Hide resolved
Co-authored-by: Bo Anderson <mail@boanderson.me>
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 22, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@carlocab carlocab merged commit 03b7611 into Homebrew:master Sep 22, 2022
@carlocab carlocab deleted the test-compiler branch September 22, 2022 21:26
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew test CompilerSelectionError when using fails_with & build-only compiler dependency
4 participants