Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debrew: fix undefined variable #14967

Merged
merged 1 commit into from Mar 14, 2023
Merged

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Mar 14, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix the exception in debug mode:

NameError: undefined local variable or method `e' for Debrew:Module

@bayandin bayandin added the critical Critical change which should be shipped as soon as possible. label Mar 14, 2023
@bayandin bayandin requested a review from issyl0 March 14, 2023 10:12
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

Thanks again @bayandin!

@MikeMcQuaid MikeMcQuaid merged commit d993167 into Homebrew:master Mar 14, 2023
@bayandin bayandin deleted the fix-undefined-e branch March 14, 2023 11:05
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants