New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils/github/actions: add format_multiline_string
method
#15002
utils/github/actions: add format_multiline_string
method
#15002
Conversation
Review period skipped due to |
# Generic GitHub Actions error. | ||
class Error < RuntimeError | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I used it here (line 30):
if name.include?(delimiter) || value.include?(delimiter)
raise Error, "`name` and `value` must not contain the delimiter"
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant: do you need to rescue
this anywhere? Otherwise you could just do
raise "`name` and `value` must not contain the delimiter"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I guess I could've just done that 🤦🏻♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too late to change it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Nice work @nandahkrishna! |
@nandahkrishna - It looks like the above change is causing an issue when I try to install the homebrew on M2 Silicon. Error=: HEAD is now at 27bb6ff Merge pull request #15002 from nandahkrishna/actions-multiline-envfile The output indicates that the HEAD of the current branch has been updated to a merge commit that merged the changes from a pull request created by the user "nandahkrishna". /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" ==> Checking for Press RETURN/ENTER to continue or any other key to abort: |
Installs now! Thanks |
@msarm The error you're seeing is unrelated to this PR, it's probably a network issue. Please try using the installer again and check the Discussions page for similar issues. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Needed for Homebrew/actions#336, see @Bo98's comment: