build(deps): bump rubocop from 1.48.1 to 1.49.0 in /Library/Homebrew #15136
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/bundler/Library/Homebrew/rubocop-1.49.0
branch
from
964e3ad
to
cf81f45
Compare
|
There seem to be two new cops that are causing linter errors in taps, The weird thing is that our custom cop tests are failing. Essentially, it now feels compelled to add the cop class name before the error message. I'm not sure we really want this behavior to be honest though it's not the end of the world if we have to settle for it. This causes like 100 failures locally. Interestingly enough I didn't see this change apply to the internal Rubocop tests when taking a glance at the diff. |
Needed for Homebrew/brew#15136.
Needed for Homebrew/brew#15136.
Needed for Homebrew/brew#15136.
Needed for Homebrew/brew#15136.
Needed for Homebrew/brew#15136.
Feels like it's doing the equivalent of running |
Needed for Homebrew/brew#15136.
|
@apainintheneck This seems to fix each individual spec but is obviously pretty ugly: --- a/Library/Homebrew/test/rubocops/caveats_spec.rb
+++ b/Library/Homebrew/test/rubocops/caveats_spec.rb
@@ -4,7 +4,7 @@
require "rubocops/caveats"
describe RuboCop::Cop::FormulaAudit::Caveats do
- subject(:cop) { described_class.new }
+ subject(:cop) { described_class.new(nil, {display_cop_names: false})}We disable these by default here: Line 16 in d15f571 but my guess is this version changes something about how configuration is picked up that means it doesn't respect that any more. I have a very mild preference to keep that setting as-is but, given @dduugg has also provided feedback about not liking this default What do you think? |
|
FWIW I tend to always add |
|
@issyl0 Good enough for me! Would you be able to pick up fixing up these tests in this PR and removing |
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in #15136 (comment) we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - #15136 (comment) - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.48.1 to 1.49.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.48.1...v1.49.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in #15136 (comment) we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - #15136 (comment) - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
issyl0
force-pushed
the
dependabot/bundler/Library/Homebrew/rubocop-1.49.0
branch
from
312a8e1
to
da734a3
Compare
- This was determinig `blank?` on a `Pathname` object, which returned `true` always, making the test fail. Instead, check the string value.
MikeMcQuaid
deleted the
dependabot/bundler/Library/Homebrew/rubocop-1.49.0
branch
|
Makes sense to me. Thanks! |
|
Thanks for getting this over the line @issyl0! 🎉 |
Bumps rubocop from 1.48.1 to 1.49.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
e534bd1Cut 1.49e72b491Update Changelogbf33f2fMerge pull request #11728 from ktopolski/add_new_data_inheritance_cop8c53464Merge pull request #11750 from koic/make_metrics_block_nesting_aware_of_numbe...bc42301[Fix #11696] Add newStyle/DataInheritancecop97a6d52MakeMetrics/BlockNestingaware of numbered parameter6cb7343Merge pull request #11748 from nobuyo/cache-root-behaviora822fee[Fix #10766] Use the path given by--cache-rootto be the parent for `ruboc...a677975[Fix #11122] Add newStyle/RedundantLineContinuationcopff383c6MakeLayout/EndAlignmentaware of pattern matchingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)